SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.3.0
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 26 |
29 |
0 |
0 |
org.eclipse.jgit.junit.LocalDiskRepositoryTestCase
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.eclipse.jgit.junit.LocalDiskRepositoryTestCase.reportDeleteFailure(boolean, File, Exception): new java.io.PrintStream(OutputStream) |
I18N |
DM_DEFAULT_ENCODING |
262 |
High |
| org.eclipse.jgit.junit.LocalDiskRepositoryTestCase.tearDown() forces garbage collection; extremely dubious except in benchmarking code |
PERFORMANCE |
DM_GC |
205 |
High |
| Exceptional return value of java.io.File.delete() ignored in org.eclipse.jgit.junit.LocalDiskRepositoryTestCase.write(String) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
559 |
Medium |
org.eclipse.jgit.junit.LocalDiskRepositoryTestCase$CleanupThread
| Bug |
Category |
Details |
Line |
Priority |
| org.eclipse.jgit.junit.LocalDiskRepositoryTestCase$CleanupThread.run() forces garbage collection; extremely dubious except in benchmarking code |
PERFORMANCE |
DM_GC |
634 |
High |
org.eclipse.jgit.junit.MockSystemReader
| Bug |
Category |
Details |
Line |
Priority |
| org.eclipse.jgit.junit.MockSystemReader.getJGitConfig() may expose internal representation by returning MockSystemReader.jgitConfig |
MALICIOUS_CODE |
EI_EXPOSE_REP |
187 |
Medium |
| org.eclipse.jgit.junit.MockSystemReader.getSystemConfig() may expose internal representation by returning MockSystemReader.systemGitConfig |
MALICIOUS_CODE |
EI_EXPOSE_REP |
193 |
Medium |
| org.eclipse.jgit.junit.MockSystemReader.getUserConfig() may expose internal representation by returning MockSystemReader.userGitConfig |
MALICIOUS_CODE |
EI_EXPOSE_REP |
182 |
Medium |
| org.eclipse.jgit.junit.MockSystemReader.openJGitConfig(Config, FS) may expose internal representation by returning MockSystemReader.jgitConfig |
MALICIOUS_CODE |
EI_EXPOSE_REP |
326 |
Medium |
| org.eclipse.jgit.junit.MockSystemReader.openSystemConfig(Config, FS) may expose internal representation by returning MockSystemReader.systemGitConfig |
MALICIOUS_CODE |
EI_EXPOSE_REP |
176 |
Medium |
| org.eclipse.jgit.junit.MockSystemReader.openUserConfig(Config, FS) may expose internal representation by returning MockSystemReader.userGitConfig |
MALICIOUS_CODE |
EI_EXPOSE_REP |
169 |
Medium |
| org.eclipse.jgit.junit.MockSystemReader.setJGitConfig(FileBasedConfig) may expose internal representation by storing an externally mutable object into MockSystemReader.jgitConfig |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
99 |
Medium |
| org.eclipse.jgit.junit.MockSystemReader.setSystemGitConfig(FileBasedConfig) may expose internal representation by storing an externally mutable object into MockSystemReader.systemGitConfig |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
112 |
Medium |
| org.eclipse.jgit.junit.MockSystemReader.setUserGitConfig(FileBasedConfig) may expose internal representation by storing an externally mutable object into MockSystemReader.userGitConfig |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
87 |
Medium |
org.eclipse.jgit.junit.RepositoryTestCase
| Bug |
Category |
Details |
Line |
Priority |
| Unread public/protected field: org.eclipse.jgit.junit.RepositoryTestCase.trash |
STYLE |
URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD |
190 |
Medium |
org.eclipse.jgit.junit.TestRepository
| Bug |
Category |
Details |
Line |
Priority |
| org.eclipse.jgit.junit.TestRepository.getRepository() may expose internal representation by returning TestRepository.db |
MALICIOUS_CODE |
EI_EXPOSE_REP |
168 |
Medium |
| org.eclipse.jgit.junit.TestRepository.getRevWalk() may expose internal representation by returning TestRepository.pool |
MALICIOUS_CODE |
EI_EXPOSE_REP |
177 |
Medium |
| org.eclipse.jgit.junit.TestRepository.git() may expose internal representation by returning TestRepository.git |
MALICIOUS_CODE |
EI_EXPOSE_REP |
188 |
Medium |
| new org.eclipse.jgit.junit.TestRepository(Repository, RevWalk, MockSystemReader) may expose internal representation by storing an externally mutable object into TestRepository.db |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
151 |
Medium |
| new org.eclipse.jgit.junit.TestRepository(Repository, RevWalk, MockSystemReader) may expose internal representation by storing an externally mutable object into TestRepository.mockSystemReader |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
155 |
Medium |
| new org.eclipse.jgit.junit.TestRepository(Repository, RevWalk, MockSystemReader) may expose internal representation by storing an externally mutable object into TestRepository.pool |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
153 |
Medium |
| Exceptional return value of java.io.File.setReadOnly() ignored in org.eclipse.jgit.junit.TestRepository.packAndPrune() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
944 |
Medium |
org.eclipse.jgit.junit.TestRepository$CommitBuilder
| Bug |
Category |
Details |
Line |
Priority |
| org.eclipse.jgit.junit.TestRepository$CommitBuilder.author() may expose internal representation by returning TestRepository$CommitBuilder.author |
MALICIOUS_CODE |
EI_EXPOSE_REP |
1287 |
Medium |
| org.eclipse.jgit.junit.TestRepository$CommitBuilder.committer() may expose internal representation by returning TestRepository$CommitBuilder.committer |
MALICIOUS_CODE |
EI_EXPOSE_REP |
1308 |
Medium |
| org.eclipse.jgit.junit.TestRepository$CommitBuilder.create() may expose internal representation by returning TestRepository$CommitBuilder.self |
MALICIOUS_CODE |
EI_EXPOSE_REP |
1375 |
Medium |
| org.eclipse.jgit.junit.TestRepository$CommitBuilder.author(PersonIdent) may expose internal representation by storing an externally mutable object into TestRepository$CommitBuilder.author |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
1277 |
Medium |
| org.eclipse.jgit.junit.TestRepository$CommitBuilder.committer(PersonIdent) may expose internal representation by storing an externally mutable object into TestRepository$CommitBuilder.committer |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
1298 |
Medium |
| org.eclipse.jgit.junit.TestRepository$CommitBuilder.ident(PersonIdent) may expose internal representation by storing an externally mutable object into TestRepository$CommitBuilder.author |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
1264 |
Medium |
| org.eclipse.jgit.junit.TestRepository$CommitBuilder.ident(PersonIdent) may expose internal representation by storing an externally mutable object into TestRepository$CommitBuilder.committer |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
1265 |
Medium |
| org.eclipse.jgit.junit.TestRepository$CommitBuilder.setTopLevelTree(ObjectId) may expose internal representation by storing an externally mutable object into TestRepository$CommitBuilder.topLevelTree |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
1155 |
Medium |
